[
https://issues.apache.org/jira/browse/BEAM-5036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597976#comment-16597976
]
Tim Robertson commented on BEAM-5036:
-------------------------------------
Thanks [~reuvenlax] - that was in response to my concern about the files
already existing right? It doesn't affect whether we use copy/delete or rename
approach, or am I missing something?
I have added {{FileAlreadyExistsException}} in the [PR for changing
HDFSFileSystem.rename()|https://github.com/apache/beam/pull/6285]. With that we
can handle the case of failure when the destination already exists, delete it
and retry thus forcing the overwrite. Together with the IGNORE_MISSING_FILES
that should be as idempotent as we can achieve I think.
Sound reasonable?
> Optimize FileBasedSink's WriteOperation.moveToOutput()
> ------------------------------------------------------
>
> Key: BEAM-5036
> URL: https://issues.apache.org/jira/browse/BEAM-5036
> Project: Beam
> Issue Type: Improvement
> Components: io-java-files
> Affects Versions: 2.5.0
> Reporter: Jozef Vilcek
> Assignee: Tim Robertson
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> moveToOutput() methods in FileBasedSink.WriteOperation implements move by
> copy+delete. It would be better to use a rename() which can be much more
> effective for some filesystems.
> Filesystem must support cross-directory rename. BEAM-4861 is related to this
> for the case of HDFS filesystem.
> Feature was discussed here:
> http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4Mp54pQ+vRrJrBh9Vx0=uaknupzd_qdh_qdm9vxll...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
