[
https://issues.apache.org/jira/browse/BEAM-3709?focusedWorklogId=139978&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-139978
]
ASF GitHub Bot logged work on BEAM-3709:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/18 07:38
Start Date: 31/Aug/18 07:38
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #6128:
[BEAM-3709] Updating combine w/ side input translation in python.
URL: https://github.com/apache/beam/pull/6128#discussion_r214267959
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -1358,6 +1358,15 @@ def expand(self, pcoll):
*args, **kwargs)
def to_runner_api_parameter(self, context):
+ # Note: Although this conditional seems identical to the one below it
+ # (if self.args or self.kwargs), there are cases where that condition
Review comment:
Could you expand on what these cases are? Could we simply eliminate them
instead of working around them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 139978)
Time Spent: 3h 10m (was: 3h)
> Implement the portable lifted Combiner transforms in Python SDK
> ---------------------------------------------------------------
>
> Key: BEAM-3709
> URL: https://issues.apache.org/jira/browse/BEAM-3709
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, sdk-py-harness
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Labels: portability
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Lifted combines are split into separate parts with different URNs. These
> parts need to be implemented in the Python SDK harness so that the SDK can
> actually execute them when receiving Combine transforms with the
> corresponding URNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
