[
https://issues.apache.org/jira/browse/BEAM-4511?focusedWorklogId=140247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-140247
]
ASF GitHub Bot logged work on BEAM-4511:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/18 20:58
Start Date: 31/Aug/18 20:58
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#6266: [BEAM-4511] added py3 tox env for first test
URL: https://github.com/apache/beam/pull/6266#discussion_r214473868
##########
File path: sdks/python/gen_protos.py
##########
@@ -110,14 +112,17 @@ def generate_proto_files(force=False):
'Protoc returned non-zero status (see logs for details): '
'%s' % ret_code)
- if sys.version_info[0] >= 3:
- ret_code = subprocess.call(
- ["futurize", "--both-stages", "--write", "--verbose", "--no-diff",
- out_dir])
+ ret_code = subprocess.call(["pip", "install", "future==0.16.0"])
Review comment:
Future needs to be installed to run the futurize step on the generated proto
files. Since gen_protos.py is called from setup.py before building, required
packages are not installed yet. I tried using setup_requires in setup.py, but
this also did not work.
This step only runs when the proto files are regenerated, so it shouldn't be
too big of a problem. However, I'm open to suggestions if there is a better way
to handle this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 140247)
Time Spent: 1h 10m (was: 1h)
> Create a tox environment that uses Py3 interpreter for pre/post commit test
> suites, once codebase supports Py3.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-4511
> URL: https://issues.apache.org/jira/browse/BEAM-4511
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
