[
https://issues.apache.org/jira/browse/BEAM-5247?focusedWorklogId=140512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-140512
]
ASF GitHub Bot logged work on BEAM-5247:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/18 09:20
Start Date: 03/Sep/18 09:20
Worklog Time Spent: 10m
Work Description: iemejia closed pull request #6284: [BEAM-5247] Remove
slf4j-simple binding from dependencies
URL: https://github.com/apache/beam/pull/6284
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/flink/build.gradle b/runners/flink/build.gradle
index 2b255d2f227..4a5d77fa15d 100644
--- a/runners/flink/build.gradle
+++ b/runners/flink/build.gradle
@@ -56,7 +56,6 @@ dependencies {
shadow project(path: ":beam-runners-java-fn-execution", configuration:
"shadow")
shadow library.java.jackson_annotations
shadow library.java.slf4j_api
- shadow library.java.slf4j_simple
shadow library.java.joda_time
shadow library.java.commons_compress
shadow library.java.args4j
@@ -74,6 +73,7 @@ dependencies {
shadowTest library.java.junit
shadowTest library.java.mockito_core
shadowTest library.java.google_api_services_bigquery
+ shadowTest library.java.slf4j_simple
shadowTest project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadow")
shadowTest library.java.jackson_dataformat_yaml
shadowTest "org.apache.flink:flink-core:$flink_version:tests"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 140512)
Time Spent: 1h 20m (was: 1h 10m)
> Remove slf4j-simple binding from dependencies
> ---------------------------------------------
>
> Key: BEAM-5247
> URL: https://issues.apache.org/jira/browse/BEAM-5247
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Jozef Vilcek
> Assignee: Jozef Vilcek
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Flink runner declares a slf4j-simple binding in dependencies. This can break
> logging of application if they have their own binding and does not exclude
> this one from beam.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
