[
https://issues.apache.org/jira/browse/BEAM-3746?focusedWorklogId=140688&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-140688
]
ASF GitHub Bot logged work on BEAM-3746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/18 18:13
Start Date: 03/Sep/18 18:13
Worklog Time Spent: 10m
Work Description: stale[bot] closed pull request #5176: [BEAM-3746] Added
error message for using Count.globally() on non-global windows
URL: https://github.com/apache/beam/pull/5176
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFnBase.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFnBase.java
index 20ec3003f2a..0c6c2983808 100644
---
a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFnBase.java
+++
b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFnBase.java
@@ -120,7 +120,9 @@
+ "PCollection is not windowed by GlobalWindows. Instead, use "
+ "Combine.globally().withoutDefaults() to output an empty PCollection
if the input "
+ "PCollection is empty, or Combine.globally().asSingletonView() to
get the default "
- + "output of the CombineFn if the input PCollection is empty.";
+ + "output of the CombineFn if the input PCollection is empty. If this
error is "
+ + "called from Count.globally(), use"
+ + "Combine.globally(Count.<T>combineFn()).withoutDefaults() instead.";
@Override
public Coder<AccumT> getAccumulatorCoder(CoderRegistry registry,
Coder<InputT> inputCoder)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 140688)
Time Spent: 1h 40m (was: 1.5h)
> Count.globally should override getIncompatibleGlobalWindowErrorMessage to
> tell the user the usage that is currently only in javadoc
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-3746
> URL: https://issues.apache.org/jira/browse/BEAM-3746
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Labels: beginner, newbie, starter
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> https://beam.apache.org/documentation/sdks/javadoc/2.3.0/org/apache/beam/sdk/transforms/Count.html#globally--
> "Note: if the input collection uses a windowing strategy other than
> GlobalWindows, use Combine.globally(Count.<T>combineFn()).withoutDefaults()
> instead."
> But the actual crash a user gets is:
> "java.lang.IllegalStateException: Default values are not supported in
> Combine.globally() if the output PCollection is not windowed by
> GlobalWindows. Instead, use Combine.globally().withoutDefaults() to output an
> empty PCollection if the input PCollection is empty, or
> Combine.globally().asSingletonView() to get the default output of the
> CombineFn if the input PCollection is empty."
> There is a method that exists solely to make this actually useful, so we
> should use it!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
