[
https://issues.apache.org/jira/browse/BEAM-5264?focusedWorklogId=140762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-140762
]
ASF GitHub Bot logged work on BEAM-5264:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/18 06:56
Start Date: 04/Sep/18 06:56
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#6304: [BEAM-5264] Reference DirectRunner implementation of Python User State
and Timers API
URL: https://github.com/apache/beam/pull/6304#discussion_r214792157
##########
File path: sdks/python/apache_beam/runners/direct/direct_runner.py
##########
@@ -105,6 +105,9 @@ def visit_transform(self, applied_ptransform):
# The FnApiRunner does not support execution of SplittableDoFns.
if DoFnSignature(dofn).is_splittable_dofn():
self.supported_by_fnapi_runner = False
+ # The FnApiRunner does not support execution of Stateful DoFns.
Review comment:
Unfortunately, the FnAPI runner does not support streaming mode and SDF (and
for that matter, things like TestStream), so we have to add this implementation
for now. You are right that we should move away from this runner. There is a
separate item on my plate to add support in the FnAPI interfaces and the Python
FnAPI runner (in the batch-only case). Fortunately, much of the code added
here is common and can be repurposed for use there too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 140762)
Time Spent: 2.5h (was: 2h 20m)
> Reference DirectRunner implementation of Python user state and timers API
> -------------------------------------------------------------------------
>
> Key: BEAM-5264
> URL: https://issues.apache.org/jira/browse/BEAM-5264
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.6.0
> Reporter: Charles Chen
> Assignee: Charles Chen
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> This issue tracks the reference DirectRunner implementation of the Beam
> Python User State and Timer API, described here:
> [https://s.apache.org/beam-python-user-state-and-timers].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
