[
https://issues.apache.org/jira/browse/BEAM-5250?focusedWorklogId=140997&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-140997
]
ASF GitHub Bot logged work on BEAM-5250:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/18 18:32
Start Date: 04/Sep/18 18:32
Worklog Time Spent: 10m
Work Description: lukecwik edited a comment on issue #6315: [BEAM-5250]
Fix GlobalWindow's max timestamp in Python SDK
URL: https://github.com/apache/beam/pull/6315#issuecomment-418469926
Max, I think the max can be defined in proto as an enum as we do with URNs
in other cases.
It is unfortunate that we tried to cram time into a 64 bit integer.
Robert, I don't think this will be easy to increase the GlobalWindow max
timestamp because in reality all of the runners [late data
utils](https://github.com/apache/beam/blob/a27ff2e45c9d0de8d84d22b0f59da187c138bb68/runners/core-java/src/main/java/org/apache/beam/runners/core/LateDataUtils.java#L53)
assume that the upper bound is actually the global window timestamp. I think
it will be easier to define max timestamp as the current global window max
timestamp then to increase the global window max timestamp. Having this gap at
the end will likely hide bugs from appearing related to end of window and
allowed lateness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 140997)
Time Spent: 1.5h (was: 1h 20m)
> Python Wordcount fails with Flink portable streaming
> ----------------------------------------------------
>
> Key: BEAM-5250
> URL: https://issues.apache.org/jira/browse/BEAM-5250
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Thomas Weise
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
