[
https://issues.apache.org/jira/browse/BEAM-4863?focusedWorklogId=141450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-141450
]
ASF GitHub Bot logged work on BEAM-4863:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/18 17:39
Start Date: 05/Sep/18 17:39
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6057:
[BEAM-4863] Implement consistentWithEquals/structuralValue on
FullWindowedValueCoder
URL: https://github.com/apache/beam/pull/6057#discussion_r215363155
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowedValue.java
##########
@@ -497,7 +497,7 @@ private void ensureWindowsAreASet() {
// right, and cast the window type away here.
@SuppressWarnings({"unchecked", "rawtypes"})
Coder<Collection<? extends BoundedWindow>> collectionCoder =
- (Coder) CollectionCoder.of(this.windowCoder);
+ (Coder) ListCoder.of(this.windowCoder);
Review comment:
Collections aren't required to be ordered (e.g. HashSet). It would be valid
to return any collection which maintains duplicates such as a multiset that
doesn't maintain order. Swapping to a ListCoder ensures that we maintain the
ordering of windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 141450)
Time Spent: 1h 10m (was: 1h)
> Implement consistentWithEquals/structuralValue on FullWindowedValueCoder
> ------------------------------------------------------------------------
>
> Key: BEAM-4863
> URL: https://issues.apache.org/jira/browse/BEAM-4863
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Implementing *consistentWithEquals*/*structuralValue* boosts significantly
> the performance of using these values in comparison operations since it
> doesn't require encoding the values.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
