[
https://issues.apache.org/jira/browse/BEAM-5301?focusedWorklogId=142262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-142262
]
ASF GitHub Bot logged work on BEAM-5301:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/18 18:12
Start Date: 07/Sep/18 18:12
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #6333:
[BEAM-5301] migrate datastore_worcount python integration test to Beam
URL: https://github.com/apache/beam/pull/6333#discussion_r216044404
##########
File path: sdks/python/apache_beam/examples/cookbook/datastore_wordcount.py
##########
@@ -84,6 +78,18 @@
from apache_beam.options.pipeline_options import PipelineOptions
from apache_beam.options.pipeline_options import SetupOptions
+# Protect against environments where datastore library is not available.
+# pylint: disable=wrong-import-order, wrong-import-position
+try:
+ from google.cloud.proto.datastore.v1 import entity_pb2
+ from google.cloud.proto.datastore.v1 import query_pb2
+ from googledatastore import helper as datastore_helper
+ from googledatastore import PropertyFilter
+ from past.builtins import unicode
+except ImportError:
+ pass
Review comment:
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 142262)
Time Spent: 1h 50m (was: 1h 40m)
> Migrate integration tests for datastore_wordcount
> -------------------------------------------------
>
> Key: BEAM-5301
> URL: https://issues.apache.org/jira/browse/BEAM-5301
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: yifan zou
> Assignee: yifan zou
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
