[
https://issues.apache.org/jira/browse/BEAM-5339?focusedWorklogId=142341&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-142341
]
ASF GitHub Bot logged work on BEAM-5339:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/18 21:54
Start Date: 07/Sep/18 21:54
Worklog Time Spent: 10m
Work Description: yifanzou closed pull request #6354: [BEAM-5339] apply
new policy on dependency tool
URL: https://github.com/apache/beam/pull/6354
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.test-infra/jenkins/jira_utils/jira_manager_test.py
b/.test-infra/jenkins/jira_utils/jira_manager_test.py
index dcf11a69e5c..a9f59b6b501 100644
--- a/.test-infra/jenkins/jira_utils/jira_manager_test.py
+++ b/.test-infra/jenkins/jira_utils/jira_manager_test.py
@@ -46,76 +46,6 @@ def setUp(self):
print("\n\nTest : " + self._testMethodName)
- def test_find_owners_with_single_owner(self, *args):
- """
- Test on _find_owners with single owner
- Expect: the primary owner is 'owner0', an empty list of other owners.
- """
- owners_yaml = """
- deps:
- dep0:
- owners: owner0,
- """
- with patch('__builtin__.open', mock_open(read_data=owners_yaml)):
- manager = JiraManager('url', 'username', 'password', owners_yaml)
- primary, owners = manager._find_owners('dep0')
- self.assertEqual(primary, 'owner0')
- self.assertEqual(len(owners), 0)
-
-
- def test_find_owners_with_multi_owners(self, *args):
- """
- Test on _find_owners with multiple owners.
- Expect: the primary owner is 'owner0', a list contains 'owner1' and
'owner2'.
- """
- owners_yaml = """
- deps:
- dep0:
- owners: owner0, owner1 , owner2,
- """
- with patch('__builtin__.open', mock_open(read_data=owners_yaml)):
- manager = JiraManager('url', 'username', 'password', owners_yaml)
- primary, owners = manager._find_owners('dep0')
- self.assertEqual(primary, 'owner0')
- self.assertEqual(len(owners), 2)
- self.assertIn('owner1', owners)
- self.assertIn('owner2', owners)
-
-
- def test_find_owners_with_no_owners_defined(self, *args):
- """
- Test on _find_owners without owner.
- Expect: the primary owner is None, an empty list of other owners.
- """
- owners_yaml = """
- deps:
- dep0:
- owners:
- """
- with patch('__builtin__.open', mock_open(read_data=owners_yaml)):
- manager = JiraManager('url', 'username', 'password', owners_yaml)
- primary, owners = manager._find_owners('dep0')
- self.assertIsNone(primary)
- self.assertEqual(len(owners), 0)
-
-
- def test_find_owners_with_no_dep_defined(self, *args):
- """
- Test on _find_owners with non-defined dep.
- Expect: through out KeyErrors. The primary owner is None, an empty list of
other owners.
- """
- owners_yaml = """
- deps:
- dep0:
- owners:
- """
- with patch('__builtin__.open', mock_open(read_data=owners_yaml)):
- manager = JiraManager('url', 'username', 'password', owners_yaml)
- primary, owners = manager._find_owners('dep1')
- self.assertIsNone(primary)
- self.assertEqual(len(owners), 0)
-
-
@patch('jira_utils.jira_manager.datetime',
Mock(today=Mock(return_value=datetime.strptime('2000-01-01', '%Y-%m-%d'))))
def test_run_with_creating_new_issue(self, *args):
"""
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 142341)
Time Spent: 0.5h (was: 20m)
> Implement new policy on Beam dependency tooling
> -----------------------------------------------
>
> Key: BEAM-5339
> URL: https://issues.apache.org/jira/browse/BEAM-5339
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: yifan zou
> Assignee: yifan zou
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> (1) Instead of a dependency "owners" list we will be maintaining an
> "interested parties" list. When we create a JIRA for a dependency we will not
> assign it to an owner but rather we will CC all the folks that mentioned that
> they will be interested in receiving updates related to that dependency. Hope
> is that some of the interested parties will also put forward the effort to
> upgrade dependencies they are interested in but the responsibility of
> upgrading dependencies lie with the community as a whole.
> (2) We will be creating JIRAs for upgrading individual dependencies, not for
> upgrading to specific versions of those dependencies. For example, if a given
> dependency X is three minor versions or an year behind we will create a JIRA
> for upgrading that. But the specific version to upgrade to has to be
> determined by the Beam community. Beam community might choose to close a JIRA
> if there are known issues with available recent releases. Tool may reopen
> such a closed JIRA in the future if new information becomes available (for
> example, 3 new versions have been released since JIRA was closed)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
