[ 
https://issues.apache.org/jira/browse/BEAM-5337?focusedWorklogId=144031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144031
 ]

ASF GitHub Bot logged work on BEAM-5337:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Sep/18 17:49
            Start Date: 13/Sep/18 17:49
    Worklog Time Spent: 10m 
      Work Description: mxm commented on a change in pull request #6385: 
[BEAM-5337] Fix flaky test UnboundedSourceWrapperTest#testValueEmission
URL: https://github.com/apache/beam/pull/6385#discussion_r217476414
 
 

 ##########
 File path: 
runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java
 ##########
 @@ -134,11 +133,13 @@ public void testValueEmission() throws Exception {
               public void run() {
                 while (true) {
                   try {
-                    synchronized (testHarness.getCheckpointLock()) {
-                      
testHarness.setProcessingTime(System.currentTimeMillis());
-                    }
+                    testHarness.setProcessingTime(System.currentTimeMillis());
                     Thread.sleep(1000);
 
 Review comment:
   Whenever processing time is advanced, the watermark timers are triggered, so 
we need to keep it advancing. The sleep releases the checkpoint lock which 
would otherwise prevent the the source wrapper from making progress.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 144031)
    Time Spent: 50m  (was: 40m)

> [beam_PostCommit_Java_GradleBuild][:beam-runners-flink_2.11:test][Flake] 
> Build times out in beam-runners-flink target
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-5337
>                 URL: https://issues.apache.org/jira/browse/BEAM-5337
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink, test-failures
>            Reporter: Mikhail Gryzykhin
>            Assignee: Maximilian Michels
>            Priority: Critical
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Job times out. 
>  Failing job url:
> [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1414/consoleFull]
> [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1406/consoleFull]
> https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1408/consoleFull
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to