[
https://issues.apache.org/jira/browse/BEAM-5372?focusedWorklogId=144217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144217
]
ASF GitHub Bot logged work on BEAM-5372:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/18 08:47
Start Date: 14/Sep/18 08:47
Worklog Time Spent: 10m
Work Description: aljoscha commented on a change in pull request #6378:
[BEAM-5372] Make minPauseBetweenCheckpoints setting available in
FlinkPipelineOptions
URL: https://github.com/apache/beam/pull/6378#discussion_r217642160
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
##########
@@ -164,6 +164,11 @@ public static StreamExecutionEnvironment
createStreamExecutionEnvironment(
? ExternalizedCheckpointCleanup.RETAIN_ON_CANCELLATION
: ExternalizedCheckpointCleanup.DELETE_ON_CANCELLATION);
}
+
+ long minPauseBetweenCheckpoints =
options.getMinPauseBetweenCheckpoints();
+ flinkStreamEnv
Review comment:
With this, we might always be overriding the Flink default if it changes, or
if it becomes configurable in the Flink config in the future.
I think we should check whether the value is different from the "Beam
default" and only set it then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 144217)
Time Spent: 40m (was: 0.5h)
> [Flink Runner] Make minPauseBetweenCheckpoints setting available in
> FlinkPipelineOptions
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-5372
> URL: https://issues.apache.org/jira/browse/BEAM-5372
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Daniel Harper
> Assignee: Daniel Harper
> Priority: Trivial
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The configuration setting {{minPauseBetweenCheckpoints}} [1] is available in
> Flink to allow a grace period when checkpoints runtime is > checkpoint
> interval.
> This should be exposed in {{FlinkPipelineOptions}} and
> {{FlinkExecutionEnvironments}} to allow users to configure this.
> The default for this value in Flink is 0ms [2]
> [1]
> https://ci.apache.org/projects/flink/flink-docs-release-1.5/api/java/org/apache/flink/streaming/api/environment/CheckpointConfig.html#setMinPauseBetweenCheckpoints-long-
> [2]
> https://ci.apache.org/projects/flink/flink-docs-release-1.5/api/java/constant-values.html#org.apache.flink.streaming.api.environment.CheckpointConfig.DEFAULT_MIN_PAUSE_BETWEEN_CHECKPOINTS
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
