[ 
https://issues.apache.org/jira/browse/BEAM-5219?focusedWorklogId=144300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144300
 ]

ASF GitHub Bot logged work on BEAM-5219:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Sep/18 14:35
            Start Date: 14/Sep/18 14:35
    Worklog Time Spent: 10m 
      Work Description: chamikaramj closed pull request #6276: [BEAM-5219] Make 
OutgoingMessage public
URL: https://github.com/apache/beam/pull/6276
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubClient.java
 
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubClient.java
index f254e1504bb..4cdf5d5b8e7 100644
--- 
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubClient.java
+++ 
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubClient.java
@@ -299,7 +299,7 @@ public static TopicPath topicPathFromName(String projectId, 
String topicName) {
    * <p>NOTE: This class is {@link Serializable} only to support the {@link 
PubsubTestClient}. Java
    * serialization is never used for non-test clients.
    */
-  static class OutgoingMessage implements Serializable {
+  public static class OutgoingMessage implements Serializable {
     /** Underlying (encoded) element. */
     public final byte[] elementBytes;
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 144300)
    Time Spent: 1h  (was: 50m)

> Expose OutboundMessage in PubSub client
> ---------------------------------------
>
>                 Key: BEAM-5219
>                 URL: https://issues.apache.org/jira/browse/BEAM-5219
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>            Reporter: Ankur Goenka
>            Assignee: Ankur Goenka
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> publish method inĀ org/apache/beam/sdk/io/gcp/pubsub/PubsubClient.java is 
> public but the argument OutboundMessage is not public which makes the api 
> unusable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to