[
https://issues.apache.org/jira/browse/BEAM-5317?focusedWorklogId=144477&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144477
]
ASF GitHub Bot logged work on BEAM-5317:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/18 22:02
Start Date: 14/Sep/18 22:02
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6397:
[BEAM-5317] Finish Python3 porting for options module
URL: https://github.com/apache/beam/pull/6397#discussion_r217853282
##########
File path: sdks/python/apache_beam/options/pipeline_options_validator_test.py
##########
@@ -329,7 +329,11 @@ def get_validator(matcher):
]
for case in test_case:
- errors = get_validator(case['on_success_matcher']).validate()
+ matcher = case['on_success_matcher']
+ if matcher and type(matcher) is bytes:
+ errors = get_validator(matcher.decode('utf-8')).validate()
Review comment:
I think we also need to fix the code that is tested by this test. It looks
like we are using a pipeline option
https://github.com/apache/beam/blob/c7d134a35dca488f0cbdf607013a6027599b96ca/sdks/python/apache_beam/options/pipeline_options.py#L671
to pass a pickled piece of code that performs some validation logic in test
pipelines. In Python 3 these pickled objects will be returned as bytes, which
we will attempt to concat to a string:
https://github.com/apache/beam/blob/c7d134a35dca488f0cbdf607013a6027599b96ca/sdks/python/apache_beam/testing/test_pipeline.py#L155
This test is running into the same problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 144477)
Time Spent: 2h 40m (was: 2.5h)
> Finish Python 3 porting for options module
> ------------------------------------------
>
> Key: BEAM-5317
> URL: https://issues.apache.org/jira/browse/BEAM-5317
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Manu Zhang
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
