[
https://issues.apache.org/jira/browse/BEAM-5264?focusedWorklogId=145219&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145219
]
ASF GitHub Bot logged work on BEAM-5264:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/18 07:21
Start Date: 18/Sep/18 07:21
Worklog Time Spent: 10m
Work Description: charlesccychen commented on issue #6304: [BEAM-5264]
Reference DirectRunner implementation of Python User State and Timers API
URL: https://github.com/apache/beam/pull/6304#issuecomment-422283005
> > Can you clarify?--I'm not sure how we can do this DirectRunner-specific
logic elsewhere (see another place this is done on line 747).
>
> I meant that we should check for key-ness and deterministic coders during
pipeline construction.
>
> > Do we know that sliding windows were already exploded? Perhaps we should
be setting self.has_windowed_inputs and relying on the window assignment from
above.
> > Ah oops I missed what you mean. I set the attribute per your suggestion.
>
> In that case, we shouldn't be re-assigning window (though perhaps worth a
comment).
Thanks, I incorporated your suggestions. PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 145219)
Time Spent: 7h 50m (was: 7h 40m)
> Reference DirectRunner implementation of Python user state and timers API
> -------------------------------------------------------------------------
>
> Key: BEAM-5264
> URL: https://issues.apache.org/jira/browse/BEAM-5264
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.6.0
> Reporter: Charles Chen
> Assignee: Charles Chen
> Priority: Major
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> This issue tracks the reference DirectRunner implementation of the Beam
> Python User State and Timer API, described here:
> [https://s.apache.org/beam-python-user-state-and-timers].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
