[
https://issues.apache.org/jira/browse/BEAM-5144?focusedWorklogId=145341&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145341
]
ASF GitHub Bot logged work on BEAM-5144:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/18 16:01
Start Date: 18/Sep/18 16:01
Worklog Time Spent: 10m
Work Description: jbonofre commented on a change in pull request #6428:
[BEAM-5144] Fix unstable test by ensuring acks are processed synchronously
URL: https://github.com/apache/beam/pull/6428#discussion_r218494299
##########
File path:
sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOTest.java
##########
@@ -101,8 +99,8 @@ public void startBroker() throws Exception {
// create JMS connection factory
connectionFactory = new ActiveMQConnectionFactory(BROKER_URL);
- connectionFactoryWithoutPrefetch =
- new ActiveMQConnectionFactory(BROKER_URL +
"?jms.prefetchPolicy.all=0");
+ connectionFactoryWithSyncAcksAndWithoutPrefetch =
+ new ActiveMQConnectionFactory(BROKER_URL +
"?jms.prefetchPolicy.all=0&jms.sendAcksAsync=false");
Review comment:
I don't think the `prefetchPolicy` is required here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 145341)
Time Spent: 1h (was: 50m)
> [beam_PostCommit_Java_GradleBuild][org.apache.beam.sdk.io.jms.JmsIOTest.testCheckpointMark][Flake]
> Expected messages count assert fails
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-5144
> URL: https://issues.apache.org/jira/browse/BEAM-5144
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Mikhail Gryzykhin
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Failing job url:
> [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1196/testReport/]
> Job history url:
> [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1245/testReport/junit/org.apache.beam.sdk.io.jms/JmsIOTest/testCheckpointMark/history/?start=50]
> Relevant log:
> java.lang.AssertionError: expected:<0> but was:<5> at
> org.junit.Assert.fail(Assert.java:88) at
> org.junit.Assert.failNotEquals(Assert.java:834) at
> org.junit.Assert.assertEquals(Assert.java:645) at
> org.junit.Assert.assertEquals(Assert.java:631) at
> org.apache.beam.sdk.io.jms.JmsIOTest.testCheckpointMark(JmsIOTest.java:324) at
>
> Multiple security exceptions found:
> java.lang.SecurityException: User name [test_user] or password is invalid.
> Aug 07, 2018 6:10:07 PM org.apache.activemq.broker.TransportConnection
> processAddConnection WARNING: Failed to add Connection
> ID:apache-beam-jenkins-slave-group-rq04-41395-1533665392741-59:9 due to {}
> java.lang.SecurityException: User name [null] or password is invalid.
>
>
> Additionally, broker service stopped errors:
> org.apache.activemq.broker.BrokerStoppedException: Broker
> BrokerService[localhost] is being stopped
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
