This is an automated email from the ASF dual-hosted git repository.
lcwik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new de2d590 Fix errors in comments (#6394)
de2d590 is described below
commit de2d590aa4f0d9476517bd6d9f3d746ebea8adb1
Author: Yueyang Qiu <[email protected]>
AuthorDate: Tue Sep 18 11:31:45 2018 -0700
Fix errors in comments (#6394)
---
.../main/java/org/apache/beam/sdk/util/ExplicitShardedFile.java | 8 +++++++-
.../org/apache/beam/sdk/util/FilePatternMatchingShardedFile.java | 3 ++-
.../main/java/org/apache/beam/sdk/util/NumberedShardedFile.java | 2 +-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExplicitShardedFile.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExplicitShardedFile.java
index f0b2fe5..944329e 100644
---
a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExplicitShardedFile.java
+++
b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExplicitShardedFile.java
@@ -58,6 +58,12 @@ public class ExplicitShardedFile implements ShardedFile {
}
}
+ /**
+ * Discovers all shards of this file using the provided {@link Sleeper} and
{@link BackOff}.
+ *
+ * <p>Because of eventual consistency, reads may discover no files or fewer
files than the
+ * explicit list of files implies. In this case, the read is considered to
have failed.
+ */
@Override
public List<String> readFilesWithRetries(Sleeper sleeper, BackOff backOff)
throws IOException, InterruptedException {
@@ -84,7 +90,7 @@ public class ExplicitShardedFile implements ShardedFile {
}
/**
- * Discovers all shards of this file using the provided {@link Sleeper} and
{@link BackOff}.
+ * Discovers all shards of this file.
*
* <p>Because of eventual consistency, reads may discover no files or fewer
files than the shard
* template implies. In this case, the read is considered to have failed.
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/FilePatternMatchingShardedFile.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/FilePatternMatchingShardedFile.java
index bbd674f..45d6087 100644
---
a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/FilePatternMatchingShardedFile.java
+++
b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/FilePatternMatchingShardedFile.java
@@ -73,6 +73,7 @@ public class FilePatternMatchingShardedFile implements
ShardedFile {
this.filePattern = filePattern;
}
+ /** Discovers all shards of this file using the provided {@link Sleeper} and
{@link BackOff}. */
@Override
public List<String> readFilesWithRetries(Sleeper sleeper, BackOff backOff)
throws IOException, InterruptedException {
@@ -106,7 +107,7 @@ public class FilePatternMatchingShardedFile implements
ShardedFile {
lastException);
}
- /** Discovers all shards of this file using the provided {@link Sleeper} and
{@link BackOff}. */
+ /** Discovers all shards of this file. */
public List<String> readFilesWithRetries() throws IOException,
InterruptedException {
return readFilesWithRetries(Sleeper.DEFAULT, BACK_OFF_FACTORY.backoff());
}
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/NumberedShardedFile.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/NumberedShardedFile.java
index d24080f..707dd7d 100644
---
a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/NumberedShardedFile.java
+++
b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/NumberedShardedFile.java
@@ -137,7 +137,7 @@ public class NumberedShardedFile implements ShardedFile {
}
/**
- * Discovers all shards of this file using the provided {@link Sleeper} and
{@link BackOff}.
+ * Discovers all shards of this file.
*
* <p>Because of eventual consistency, reads may discover no files or fewer
files than the shard
* template implies. In this case, the read is considered to have failed.
