[
https://issues.apache.org/jira/browse/BEAM-5299?focusedWorklogId=145635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145635
]
ASF GitHub Bot logged work on BEAM-5299:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Sep/18 12:05
Start Date: 19/Sep/18 12:05
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6381:
[BEAM-5299] Define max timestamp for global window in proto
URL: https://github.com/apache/beam/pull/6381#discussion_r218776145
##########
File path: sdks/java/core/build.gradle
##########
@@ -51,6 +51,8 @@ test {
}
dependencies {
+ // Required to loads constants from the model, e.g. max timestamp for global
window
+ shadow project(path: ":beam-model-pipeline", configuration: "shadow")
Review comment:
The goal is to have the max global window timestamp _once_ defined globally
across all sdks. `beam-model-pipeline` is the proto definition which all SDKs
depend on.
In Python the module structure is much simpler and we just have the proto
always available. In java, due to the runners being in java, we have a separate
`beam-sds-java-core` module which so far doesn't depend on the pipeline module.
We have two options 1) depend on the pipeline definition in java-core 2)
move GlobalWindow from java-core (I found this to be pretty tricky).
You propose to factor out the timestamp into a new module and let all sdks
depend on that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 145635)
Time Spent: 1h 50m (was: 1h 40m)
> Define max global window as a shared value in protos like URN enums.
> --------------------------------------------------------------------
>
> Key: BEAM-5299
> URL: https://issues.apache.org/jira/browse/BEAM-5299
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: portability
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Instead of having each language define a max timestamp themselves, define the
> max timestamps within proto to be shared across different languages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
