[
https://issues.apache.org/jira/browse/BEAM-3884?focusedWorklogId=145830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145830
]
ASF GitHub Bot logged work on BEAM-3884:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Sep/18 21:47
Start Date: 19/Sep/18 21:47
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6376:
[BEAM-3884] Implement Impulse primitive in FnApiRunner.
URL: https://github.com/apache/beam/pull/6376#discussion_r218959767
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -885,7 +952,10 @@ def extract_endpoints(stage):
pcoll_id = transform.spec.payload
if transform.spec.urn == bundle_processor.DATA_INPUT_URN:
target = transform.unique_name, only_element(transform.outputs)
- data_input[target] = pcoll_buffers[pcoll_id]
+ if pcoll_id.startswith('impulse:'):
Review comment:
nit: Shall we make impulse: a constant to make impulse name pattern more
explicit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 145830)
Time Spent: 3h (was: 2h 50m)
> Python SDK supports Impulse as a primitive transform
> ----------------------------------------------------
>
> Key: BEAM-3884
> URL: https://issues.apache.org/jira/browse/BEAM-3884
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ben Sidhom
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Portable runners require Impulse to be the only root nodes of pipelines. The
> Python SDK should provide this for pipeline construction.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
