[
https://issues.apache.org/jira/browse/BEAM-5430?focusedWorklogId=146130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146130
]
ASF GitHub Bot logged work on BEAM-5430:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/18 21:14
Start Date: 20/Sep/18 21:14
Worklog Time Spent: 10m
Work Description: HuangLED opened a new pull request #6454: [BEAM-5430]
Adjust implementation of CombineGroupedValues runner to use CombineFn.apply
URL: https://github.com/apache/beam/pull/6454
**Please** add a meaningful description for your change here
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 146130)
Time Spent: 10m
Remaining Estimate: 0h
> Adjust implementation of CombineGroupedValues runner to use CombineFn.apply
> ---------------------------------------------------------------------------
>
> Key: BEAM-5430
> URL: https://issues.apache.org/jira/browse/BEAM-5430
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Reporter: Daniel Oliveira
> Assignee: Ruoyun Huang
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the [implementation for the runner of
> Combine.GroupedValues|https://github.com/apache/beam/blob/bdd0081b49f8e7df6733dc8e8bc90dda3efc6621/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/CombineRunners.java#L217]
> in the Java SDK it essentially re-implements what was already implemented in
> [CombineFn.apply|https://github.com/apache/beam/blob/bdd0081b49f8e7df6733dc8e8bc90dda3efc6621/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java#L348].
> The implementation should instead just call CombineFn.apply for simplicity
> and code reuse.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
