[
https://issues.apache.org/jira/browse/BEAM-2687?focusedWorklogId=146302&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146302
]
ASF GitHub Bot logged work on BEAM-2687:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/18 09:45
Start Date: 21/Sep/18 09:45
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#6433: [BEAM-2687] Implement Timers over the Fn API.
URL: https://github.com/apache/beam/pull/6433#discussion_r219441690
##########
File path: sdks/python/apache_beam/runners/worker/operations.py
##########
@@ -296,10 +297,11 @@ class DoOperation(Operation):
def __init__(
self, name, spec, counter_factory, sampler, side_input_maps=None,
- user_state_context=None):
+ user_state_context=None, timer_inputs=None):
super(DoOperation, self).__init__(name, spec, counter_factory, sampler)
self.side_input_maps = side_input_maps
self.user_state_context = user_state_context
+ self.timer_inputs = timer_inputs or {}
Review comment:
Can you comment in the pydoc what this is supposed to be, especially since
this is never really used in this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 146302)
Time Spent: 4h 40m (was: 4.5h)
> Python SDK support for Stateful Processing
> ------------------------------------------
>
> Key: BEAM-2687
> URL: https://issues.apache.org/jira/browse/BEAM-2687
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Charles Chen
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Python SDK should support stateful processing
> (https://beam.apache.org/blog/2017/02/13/stateful-processing.html)
> In the meantime, runner capability matrix should be updated to show the lack
> of this feature
> (https://beam.apache.org/documentation/runners/capability-matrix/)
> Use this as an umbrella issue for all related issues.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
