[
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=146323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146323
]
ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/18 10:40
Start Date: 21/Sep/18 10:40
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #6447:
[BEAM-5442] Add FlinkOptions to Python SDK
URL: https://github.com/apache/beam/pull/6447#discussion_r219454131
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -662,6 +662,23 @@ def _add_argparse_args(cls, parser):
'in the pipeline when running using the Fn API.'))
+class FlinkOptions(PipelineOptions):
+
+ @classmethod
+ def _add_argparse_args(cls, parser):
+ parser.add_argument('--flink_master',
+ type=str,
+ help=
+ ('Addres of the Flink master where the Pipeline '
+ 'should be executed. Can either be of the form '
+ '\'host:port\' or one of the special values '
+ '[local], [collection], or [auto].'))
+ parser.add_argument('--parallelism',
Review comment:
Flags are inherently a global namespace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 146323)
Time Spent: 1.5h (was: 1h 20m)
> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
> Key: BEAM-5442
> URL: https://issues.apache.org/jira/browse/BEAM-5442
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Fix For: 2.8.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the
> PortableRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
