[
https://issues.apache.org/jira/browse/BEAM-5427?focusedWorklogId=147204&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147204
]
ASF GitHub Bot logged work on BEAM-5427:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/18 16:55
Start Date: 24/Sep/18 16:55
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6439:
[BEAM-5427] Fix and update sample code for CombineFn.
URL: https://github.com/apache/beam/pull/6439#discussion_r219911068
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java
##########
@@ -254,10 +254,26 @@ private Combine() {
*
* <pre>{@code
* public class AverageFn extends CombineFn<Integer, AverageFn.Accum,
Double> {
- * public static class Accum {
+ * public static class Accum implements java.io.Serializable {
Review comment:
If you want to fully qualify Serializable, you'll want to fully qualify all
the other types such as CombineFn, Combine, and PCollection which that are part
of the example. Consider dropping the `java.io.` part instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 147204)
Time Spent: 2h 20m (was: 2h 10m)
> Fix sample code (AverageFn) in Combine.java
> -------------------------------------------
>
> Key: BEAM-5427
> URL: https://issues.apache.org/jira/browse/BEAM-5427
> Project: Beam
> Issue Type: Improvement
> Components: examples-java
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Sample code missing coder.
> In its current state, job run fails with Coder missing error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
