[
https://issues.apache.org/jira/browse/BEAM-5487?focusedWorklogId=147293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147293
]
ASF GitHub Bot logged work on BEAM-5487:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/18 20:34
Start Date: 24/Sep/18 20:34
Worklog Time Spent: 10m
Work Description: lukecwik opened a new pull request #6481: [BEAM-5487]
ByteKeyRangeTracker restrictions do not cover the entire interval because of
incorrect next key
URL: https://github.com/apache/beam/pull/6481
The definition of next for a byte key is incorrectly set as old key + 1 when
treating the key as the next largest value, for example:
0x01 is the next key for 0x00
The ByteKey compareTo operator treats two keys where one key is the proper
prefix of the other as smaller hence 0x01 is greater then 0x00, but so is
0x0000 thus next is skipping over 0x0000 as the next smallest key larger then
0x00.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 147293)
Time Spent: 10m
Remaining Estimate: 0h
> ByteKeyRangeTracker restrictions do not cover the entire interval because of
> incorrect next key
> -----------------------------------------------------------------------------------------------
>
> Key: BEAM-5487
> URL: https://issues.apache.org/jira/browse/BEAM-5487
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The definition of next for a byte key is incorrectly set as old key + 1 when
> treating the key as the next largest value, for example
> 0x01 is the next key for 0x00
>
> The ByteKey compareTo operator treats two keys where one key is the proper
> prefix of the other as smaller hence 0x01 is greater then 0x00, but so is
> 0x0000 thus next is skipping over 0x0000 as the next smallest key larger then
> 0x00.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
