[
https://issues.apache.org/jira/browse/BEAM-5339?focusedWorklogId=147328&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147328
]
ASF GitHub Bot logged work on BEAM-5339:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/18 21:44
Start Date: 24/Sep/18 21:44
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#6430: [BEAM-5339]/apply new policy on Beam dependency tooling
URL: https://github.com/apache/beam/pull/6430#discussion_r219999412
##########
File path: .test-infra/jenkins/dependency_check/version_comparer_test.py
##########
@@ -0,0 +1,50 @@
+#!/usr/bin/env python
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import version_comparer
+import unittest
+
+class VersionComparerTest(unittest.TestCase):
+ """Tests for `version_comparer.py`."""
+
+ def setUp(self):
+ print("\n\nTest : " + self._testMethodName)
+
+
+ def test_compare_major_verison_true(self):
+ curr_ver = '1.0.0'
+ latest_ver = '2.0.0'
+ self.assertTrue(version_comparer.compare_dependency_versions(curr_ver,
latest_ver))
+
+ def test_compare_minor_version_true(self):
+ curr_ver = '1.0.0'
+ latest_ver = '1.3.0'
+ self.assertTrue(version_comparer.compare_dependency_versions(curr_ver,
latest_ver))
+
+ def test_compare_non_semantic_version_true(self):
+ curr_ver = '1.rc1'
+ latest_ver = '1.rc2'
+ self.assertTrue(version_comparer.compare_dependency_versions(curr_ver,
latest_ver))
+
+ def test_compare_minor_version_false(self):
Review comment:
Please also add a test for current minor version == latest minor version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 147328)
Time Spent: 2.5h (was: 2h 20m)
> Implement new policy on Beam dependency tooling
> -----------------------------------------------
>
> Key: BEAM-5339
> URL: https://issues.apache.org/jira/browse/BEAM-5339
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: yifan zou
> Assignee: yifan zou
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> (1) Instead of a dependency "owners" list we will be maintaining an
> "interested parties" list. When we create a JIRA for a dependency we will not
> assign it to an owner but rather we will CC all the folks that mentioned that
> they will be interested in receiving updates related to that dependency. Hope
> is that some of the interested parties will also put forward the effort to
> upgrade dependencies they are interested in but the responsibility of
> upgrading dependencies lie with the community as a whole.
> (2) We will be creating JIRAs for upgrading individual dependencies, not for
> upgrading to specific versions of those dependencies. For example, if a given
> dependency X is three minor versions or an year behind we will create a JIRA
> for upgrading that. But the specific version to upgrade to has to be
> determined by the Beam community. Beam community might choose to close a JIRA
> if there are known issues with available recent releases. Tool may reopen
> such a closed JIRA in the future if new information becomes available (for
> example, 3 new versions have been released since JIRA was closed)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
