[
https://issues.apache.org/jira/browse/BEAM-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626584#comment-16626584
]
Ahmet Altay commented on BEAM-5490:
-----------------------------------
First option with a modified copy of the functions sounds like a better idea.
It should not be hard to make a pass and replace existing use.
> Beam should not irreversibly modify inspect.getargspec
> ------------------------------------------------------
>
> Key: BEAM-5490
> URL: https://issues.apache.org/jira/browse/BEAM-5490
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chuan Yu Foo
> Assignee: Ahmet Altay
> Priority: Major
>
> In the Python SDK, in {{typehints/decorators.py}}, Beam irreversibly
> monkey-patches {{inspect.getargspec}} for its own purposes. This is really
> bad form, since it leads to hard to debug issues in other modules which also
> use {{inspect.getargspec}} when Beam is imported.
> Beam should either maintain its own modified copy of the functions it needs,
> or else it should always reverse the monkey-patching so that it does not
> affect other modules.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
