[
https://issues.apache.org/jira/browse/BEAM-5288?focusedWorklogId=147568&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147568
]
ASF GitHub Bot logged work on BEAM-5288:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/18 13:49
Start Date: 25/Sep/18 13:49
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #6441:
[BEAM-5288] Support environment pipeline option in Java and Python.
URL: https://github.com/apache/beam/pull/6441#discussion_r220196784
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/PortableExecutionTest.java
##########
@@ -117,7 +84,12 @@ public void tearDown() {
@Test
public void testExecution() throws Exception {
- Pipeline p = Pipeline.create();
+ PipelineOptions options = PipelineOptionsFactory.create();
+ options.setRunner(CrashingRunner.class);
+ options.as(FlinkPipelineOptions.class).setFlinkMaster("[local]");
+ options.as(FlinkPipelineOptions.class).setStreaming(isStreaming);
+
options.as(PortablePipelineOptions.class).setDefaultJavaEnvironmentType("EMBEDDED");
Review comment:
use `ENVIRONMENT_EMBEDDED` constant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 147568)
Time Spent: 10h 10m (was: 10h)
> Modify Environment to support non-dockerized SDK harness deployments
> ---------------------------------------------------------------------
>
> Key: BEAM-5288
> URL: https://issues.apache.org/jira/browse/BEAM-5288
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Maximilian Michels
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
> As of mailing discussions and BEAM-5187, it has become clear that we need to
> extend the Environment information. In addition to the Docker environment,
> the extended environment holds deployment options for 1) a process-based
> environment, 2) an externally managed environment.
> The proto definition, as of now, looks as follows:
> {noformat}
> message Environment {
> // (Required) The URN of the payload
> string urn = 1;
> // (Optional) The data specifying any parameters to the URN. If
> // the URN does not require any arguments, this may be omitted.
> bytes payload = 2;
> }
> message StandardEnvironments {
> enum Environments {
> DOCKER = 0 [(beam_urn) = "beam:env:docker:v1"];
> PROCESS = 1 [(beam_urn) = "beam:env:process:v1"];
> EXTERNAL = 2 [(beam_urn) = "beam:env:external:v1"];
> }
> }
> // The payload of a Docker image
> message DockerPayload {
> string container_image = 1; // implicitly linux_amd64.
> }
> message ProcessPayload {
> string os = 1; // "linux", "darwin", ..
> string arch = 2; // "amd64", ..
> string command = 3; // process to execute
> map<string, string> env = 4; // environment variables
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
