[
https://issues.apache.org/jira/browse/BEAM-5319?focusedWorklogId=147746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147746
]
ASF GitHub Bot logged work on BEAM-5319:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/18 19:55
Start Date: 25/Sep/18 19:55
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#6451: [BEAM-5319] Partially port runners
URL: https://github.com/apache/beam/pull/6451#discussion_r220332999
##########
File path: sdks/python/apache_beam/io/textio.py
##########
@@ -147,7 +147,7 @@ def display_data(self):
def read_records(self, file_name, range_tracker):
start_offset = range_tracker.start_position()
- read_buffer = _TextSource.ReadBuffer('', 0)
+ read_buffer = _TextSource.ReadBuffer(b'', 0)
Review comment:
You're right.
I haven't focused too much on the `io` files yet, since this package still
needs to be ported. However, since it is related to this change, I will already
add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 147746)
Time Spent: 2h 10m (was: 2h)
> Finish Python 3 porting for runners module
> ------------------------------------------
>
> Key: BEAM-5319
> URL: https://issues.apache.org/jira/browse/BEAM-5319
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
