[
https://issues.apache.org/jira/browse/BEAM-5036?focusedWorklogId=149266&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-149266
]
ASF GitHub Bot logged work on BEAM-5036:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/18 19:04
Start Date: 28/Sep/18 19:04
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#6289: [BEAM-5036] Optimize the FileBasedSink WriteOperation.moveToOutput()
URL: https://github.com/apache/beam/pull/6289#discussion_r220806709
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java
##########
@@ -298,6 +299,12 @@ public static void copy(
*
* <p>It doesn't support renaming globs.
*
+ * <p>If the underlying file system reports that a target file already
exists and moveOptions
+ * contains {@code StandardMoveOptions.REPLACE_EXISTING} then all target
files that existed prior
+ * to calling rename will be deleted and the rename retried. When a retry is
attempted then
+ * missing files from the source will be ignored. Some filesystem
implementations will <em>always
Review comment:
nit: {@code FileSystem}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 149266)
Time Spent: 6h (was: 5h 50m)
> Optimize FileBasedSink's WriteOperation.moveToOutput()
> ------------------------------------------------------
>
> Key: BEAM-5036
> URL: https://issues.apache.org/jira/browse/BEAM-5036
> Project: Beam
> Issue Type: Improvement
> Components: io-java-files
> Affects Versions: 2.5.0
> Reporter: Jozef Vilcek
> Assignee: Tim Robertson
> Priority: Major
> Time Spent: 6h
> Remaining Estimate: 0h
>
> moveToOutput() methods in FileBasedSink.WriteOperation implements move by
> copy+delete. It would be better to use a rename() which can be much more
> effective for some filesystems.
> Filesystem must support cross-directory rename. BEAM-4861 is related to this
> for the case of HDFS filesystem.
> Feature was discussed here:
> http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4Mp54pQ+vRrJrBh9Vx0=uaknupzd_qdh_qdm9vxll...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
