[
https://issues.apache.org/jira/browse/BEAM-5443?focusedWorklogId=149661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-149661
]
ASF GitHub Bot logged work on BEAM-5443:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/18 17:57
Start Date: 29/Sep/18 17:57
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #6512:
[BEAM-5443] Pipeline option defaults for portable runner.
URL: https://github.com/apache/beam/pull/6512#discussion_r221435468
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -104,6 +105,11 @@ def _create_environment(options):
def run_pipeline(self, pipeline):
portable_options = pipeline.options.view_as(PortableOptions)
job_endpoint = portable_options.job_endpoint
+
+ # portable runner specific default
+ if pipeline.options.view_as(SetupOptions).sdk_location == 'default':
+ pipeline.options.view_as(SetupOptions).sdk_location = 'container'
Review comment:
@mxm I don't think it can be deferred to the runner, the stager behavior
depends on it. I would prefer that the stager does nothing unless a specific
option was set (like `pypi` in dataflow case), but that should probably be a
separate change. It would allow us to not even touch the value in portable
runner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 149661)
Time Spent: 2h 50m (was: 2h 40m)
> Simplify Python pipeline options for portable runner
> ----------------------------------------------------
>
> Key: BEAM-5443
> URL: https://issues.apache.org/jira/browse/BEAM-5443
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Affects Versions: 2.7.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Currently, the user needs to specify several extra pipeline options to run a
> Python pipeline with the portable runner. It would be nice to remove the need
> to explicitly provide these options when they can be inferred / have defaults.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
