[
https://issues.apache.org/jira/browse/BEAM-2953?focusedWorklogId=150814&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-150814
]
ASF GitHub Bot logged work on BEAM-2953:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Oct/18 16:29
Start Date: 03/Oct/18 16:29
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #6540:
[BEAM-2953] Advanced Timeseries examples.
URL: https://github.com/apache/beam/pull/6540#discussion_r222378934
##########
File path: examples/java/src/main/proto/TimeSeriesData.proto
##########
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to you under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+syntax = "proto3";
+
+package protos;
+
+import "google/protobuf/duration.proto";
+import "google/protobuf/timestamp.proto";
+option java_outer_classname = "TimeSeriesData";
+option java_multiple_files = false;
+option java_package = "org.apache.beam.examples.timeseries.protos";
+
+// The TimeSeriesData proto type will be used as the internal
representation of all timeseries within the the TS
Review comment:
Is it a requirement for this to be a Proto (e.g. if you're planning to add
cross-language support)? If not, then I personally would suggest to using raw
Java classes instead. I imagine not everyone is familiar with protos, plus you
can have more customization options for Java classes, e.g. introduce utility
and/or factory methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 150814)
Time Spent: 1h 40m (was: 1.5h)
> Create more advanced Timeseries processing examples using state API
> -------------------------------------------------------------------
>
> Key: BEAM-2953
> URL: https://issues.apache.org/jira/browse/BEAM-2953
> Project: Beam
> Issue Type: Improvement
> Components: examples-java
> Affects Versions: 2.1.0
> Reporter: Reza ardeshir rokni
> Assignee: Reuven Lax
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> As described in the phase 1 portion of this solution outline:
> https://cloud.google.com/solutions/correlating-time-series-dataflow
> BEAM can be used to build out some very interesting pre-processing stages for
> time series data. Some examples that will be useful:
> - Downsampling time series based on simple AVG, MIN, MAX
> - Creating a value for each time window using generatesequence as a seed
> - Loading the value of a downsample with the previous value (used in FX with
> previous close being brought into current open value)
> This will show some concrete examples of keyed state as well as the use of
> combiners.
> The samples can also be used to show how you can create a ordered list of
> values per key from a unbounded topic which has multiple time series keys.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
