[
https://issues.apache.org/jira/browse/BEAM-4495?focusedWorklogId=150973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-150973
]
ASF GitHub Bot logged work on BEAM-4495:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Oct/18 23:16
Start Date: 03/Oct/18 23:16
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #6546:
[BEAM-4495] Create precommit to stage website on GCS
URL: https://github.com/apache/beam/pull/6546#discussion_r222422766
##########
File path: .test-infra/jenkins/PrecommitJobBuilder.groovy
##########
@@ -103,6 +103,7 @@ class PrecommitJobBuilder {
rootBuildScriptDir(commonJobProperties.checkoutDir)
tasks(gradleTask)
commonJobProperties.setGradleSwitches(delegate)
+ switches('-PpullId=${ghprbPullId}')
Review comment:
`pullId` isn't very descriptive when taken out of context, and it's defined
as a global gradle command-line flag. Could we make it more descriptive, i.e.
`githubPullRequestId` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 150973)
Time Spent: 10h 50m (was: 10h 40m)
> Create website pre-commits for apache/beam repository
> -----------------------------------------------------
>
> Key: BEAM-4495
> URL: https://issues.apache.org/jira/browse/BEAM-4495
> Project: Beam
> Issue Type: Sub-task
> Components: testing, website
> Reporter: Scott Wegner
> Assignee: Udi Meiri
> Priority: Major
> Labels: beam-site-automation-reliability
> Fix For: Not applicable
>
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
