[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=151256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151256
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/18 16:09
Start Date: 04/Oct/18 16:09
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #6563:
[BEAM-4176] Cleanup SDK Harness docker container
URL: https://github.com/apache/beam/pull/6563#discussion_r222733149
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerEnvironmentFactory.java
##########
@@ -225,6 +233,11 @@ private static ServerFactory getServerFactory() {
/** Provider for DockerEnvironmentFactory. */
public static class Provider implements EnvironmentFactory.Provider {
+ private final boolean cleanup;
Review comment:
I suspect there will be many other docker options that we eventually would
want to expose, especially for local runs. Mounts, networking, etc. Perhaps it
would make sense to use a structure similar to ManualDockerEnvironmentOptions
mentioned below to avoid updating the plumbing multiple times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 151256)
Time Spent: 28h 40m (was: 28.5h)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Assignee: Ankur Goenka
> Priority: Major
> Attachments: 81VxNWtFtke.png, Screen Shot 2018-08-14 at 4.18.31
> PM.png, Screen Shot 2018-09-03 at 11.07.38 AM.png
>
> Time Spent: 28h 40m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
