[
https://issues.apache.org/jira/browse/BEAM-5036?focusedWorklogId=151342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151342
]
ASF GitHub Bot logged work on BEAM-5036:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/18 19:32
Start Date: 04/Oct/18 19:32
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#6289: [BEAM-5036] Optimize the FileBasedSink WriteOperation.moveToOutput()
URL: https://github.com/apache/beam/pull/6289#discussion_r222798220
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/LocalFileSystem.java
##########
@@ -169,11 +183,7 @@ protected void rename(List<LocalResourceId>
srcResourceIds, List<LocalResourceId
dst.getPath());
}
// Rename the source file, replacing the existing destination.
- Files.move(
- src.getPath(),
- dst.getPath(),
- StandardCopyOption.REPLACE_EXISTING,
- StandardCopyOption.ATOMIC_MOVE);
+ Files.move(src.getPath(), dst.getPath(), renameCopyOption);
Review comment:
We should probably catch java.nio.file.FileAlreadyExistsException here and
raise java.io.FileNotFoundException according to the spec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 151342)
Time Spent: 10h 20m (was: 10h 10m)
> Optimize FileBasedSink's WriteOperation.moveToOutput()
> ------------------------------------------------------
>
> Key: BEAM-5036
> URL: https://issues.apache.org/jira/browse/BEAM-5036
> Project: Beam
> Issue Type: Improvement
> Components: io-java-files
> Affects Versions: 2.5.0
> Reporter: Jozef Vilcek
> Assignee: Tim Robertson
> Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> moveToOutput() methods in FileBasedSink.WriteOperation implements move by
> copy+delete. It would be better to use a rename() which can be much more
> effective for some filesystems.
> Filesystem must support cross-directory rename. BEAM-4861 is related to this
> for the case of HDFS filesystem.
> Feature was discussed here:
> http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4Mp54pQ+vRrJrBh9Vx0=uaknupzd_qdh_qdm9vxll...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
