[
https://issues.apache.org/jira/browse/BEAM-3904?focusedWorklogId=151369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151369
]
ASF GitHub Bot logged work on BEAM-3904:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/18 20:53
Start Date: 04/Oct/18 20:53
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #6552: [BEAM-3904] Remove
default worker id in python
URL: https://github.com/apache/beam/pull/6552
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/runners/worker/worker_id_interceptor.py
b/sdks/python/apache_beam/runners/worker/worker_id_interceptor.py
index f2ca4e79f72..7b2c9cfbf4f 100644
--- a/sdks/python/apache_beam/runners/worker/worker_id_interceptor.py
+++ b/sdks/python/apache_beam/runners/worker/worker_id_interceptor.py
@@ -21,7 +21,6 @@
import collections
import os
-import uuid
import grpc
@@ -39,7 +38,7 @@ class WorkerIdInterceptor(grpc.StreamStreamClientInterceptor):
# and throw exception in worker_id_interceptor.py after we have rolled out
# the corresponding container changes.
# Unique worker Id for this worker.
- _worker_id = os.environ.get('WORKER_ID', str(uuid.uuid4()))
+ _worker_id = os.environ.get('WORKER_ID')
def __init__(self):
pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 151369)
Time Spent: 1h (was: 50m)
> Don't use UUID when worker_id is missing
> ----------------------------------------
>
> Key: BEAM-3904
> URL: https://issues.apache.org/jira/browse/BEAM-3904
> Project: Beam
> Issue Type: Task
> Components: sdk-py-harness
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Removed defaulting to UUID when worker_id is not present and throw exception
> in worker_id_interceptor.py after we have rolled out the corresponding
> container changes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
