[
https://issues.apache.org/jira/browse/BEAM-5202?focusedWorklogId=151670&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151670
]
ASF GitHub Bot logged work on BEAM-5202:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/18 16:35
Start Date: 05/Oct/18 16:35
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #6580:
[BEAM-5202] register UDF/UDAF with ServiceLoader
URL: https://github.com/apache/beam/pull/6580#discussion_r223065110
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlEnv.java
##########
@@ -100,6 +105,22 @@ public void registerUdaf(String functionName,
Combine.CombineFn combineFn) {
defaultSchema.add(functionName, new UdafImpl(combineFn));
}
+ /** Load all UDF/UDAF from {@link UdfUdafRegister}. */
+ public void autoRegisterUdfUdaf() {
+ for (UdfUdafRegister ins :
+
Lists.newArrayList(ServiceLoader.<UdfUdafRegister>load(UdfUdafRegister.class)))
{
Review comment:
nit: `Lists.newArrayList` is unneeded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 151670)
Time Spent: 40m (was: 0.5h)
> register UDF/UDAF with ServiceLoader
> ------------------------------------
>
> Key: BEAM-5202
> URL: https://issues.apache.org/jira/browse/BEAM-5202
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> create a ServiceLoader for UDF/UDAF register, if the autoLoad option is set
> to TRUE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
