[
https://issues.apache.org/jira/browse/BEAM-5641?focusedWorklogId=151702&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151702
]
ASF GitHub Bot logged work on BEAM-5641:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/18 17:05
Start Date: 05/Oct/18 17:05
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #6566:
[BEAM-5641] Move mock classes to sql src/main
URL: https://github.com/apache/beam/pull/6566#discussion_r223076128
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/test/MockUtils.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.sql.meta.provider.test;
+
+import static java.util.stream.Collectors.toList;
+import static org.apache.beam.sdk.schemas.Schema.toSchema;
+import static org.apache.beam.sdk.values.Row.toRow;
+
+import com.google.common.collect.Lists;
+import java.util.List;
+import java.util.stream.Stream;
+import org.apache.beam.sdk.annotations.Experimental;
+import org.apache.beam.sdk.schemas.Schema;
+import org.apache.beam.sdk.schemas.Schema.FieldType;
+import org.apache.beam.sdk.values.Row;
+
+/** Utility functions for mock classes. */
+@Experimental
+public class MockUtils {
+ public static Schema buildBeamSqlSchema(Object... args) {
Review comment:
Mocking in Java is usually linked to `mockito`, I think we should avoid
naming things `MockBlah` unless they're actually `mockito` mocks. Can we rename
these to `TableTestUtils` or something similar?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 151702)
Time Spent: 40m (was: 0.5h)
> Move mock classes to sql src/main
> ---------------------------------
>
> Key: BEAM-5641
> URL: https://issues.apache.org/jira/browse/BEAM-5641
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
