[
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=151842&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151842
]
ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/18 20:12
Start Date: 05/Oct/18 20:12
Worklog Time Spent: 10m
Work Description: swegner closed pull request #6589: [BEAM-5442] Attempt
to fix postcommit breakage.
URL: https://github.com/apache/beam/pull/6589
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/options/pipeline_options.py
b/sdks/python/apache_beam/options/pipeline_options.py
index bc8c962bcd4..a86cab9a84c 100644
--- a/sdks/python/apache_beam/options/pipeline_options.py
+++ b/sdks/python/apache_beam/options/pipeline_options.py
@@ -220,12 +220,13 @@ def get_all_options(self, drop_default=False):
if unknown_args and unknown_args[0] != '':
logging.info("Parsing unknown args: %s", unknown_args)
for arg in unknown_args:
- if arg.startswith('--'):
+ # https://issues.apache.org/jira/browse/BEAM-5442
+ if arg.startswith('--') and not arg.startswith('--beam_plugins'):
parser.add_argument(arg.split('=', 1)[0], nargs='?')
# repeat parsing with unknown options added
known_args, unknown_args = parser.parse_known_args(self._flags)
if unknown_args:
- logging.warn("Discarding unparseable args: %s", unknown_args)
+ logging.warning("Discarding unparseable args: %s", unknown_args)
result = vars(known_args)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 151842)
Time Spent: 6h (was: 5h 50m)
> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
> Key: BEAM-5442
> URL: https://issues.apache.org/jira/browse/BEAM-5442
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Fix For: 2.8.0
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the
> PortableRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
