[
https://issues.apache.org/jira/browse/BEAM-5644?focusedWorklogId=151933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151933
]
ASF GitHub Bot logged work on BEAM-5644:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/18 00:15
Start Date: 06/Oct/18 00:15
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #6598:
[BEAM-5644] make planner impl configurable
URL: https://github.com/apache/beam/pull/6598#discussion_r223164134
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamQueryPlanner.java
##########
@@ -97,6 +102,12 @@
.typeSystem(connection.getTypeFactory().getTypeSystem())
.operatorTable(ChainedSqlOperatorTable.of(opTab0, catalogReader))
.build();
+
+ options = PipelineOptionsFactory.create();
+ }
+
+ public void setOptions(PipelineOptions options) {
Review comment:
I would argue this should be more like `setPlannerFactory()` taking either a
`String` or `Constructor`. I like the `PipelineOptions` approach, I just don't
think they belong in `BeamQueryPlanner`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 151933)
Time Spent: 40m (was: 0.5h)
> make Planner configurable
> --------------------------
>
> Key: BEAM-5644
> URL: https://issues.apache.org/jira/browse/BEAM-5644
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We can make planner configurable here:
> [BeamQueryPlanner.java#L145|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamQueryPlanner.java#L145]
>
> By doing so, we can have different planner implementation to support
> different SQL dialect.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
