[
https://issues.apache.org/jira/browse/BEAM-5626?focusedWorklogId=152264&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152264
]
ASF GitHub Bot logged work on BEAM-5626:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/18 14:53
Start Date: 08/Oct/18 14:53
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6587:
[BEAM-5626] Fix hadoop filesystem test for py3.
URL: https://github.com/apache/beam/pull/6587#discussion_r223393229
##########
File path: sdks/python/apache_beam/io/hadoopfilesystem_test.py
##########
@@ -153,7 +153,7 @@ def delete(self, path, recursive=True):
_ = self.status(path)
- for filepath in self.files.keys(): # pylint:
disable=consider-iterating-dictionary
+ for filepath in list(self.files):
Review comment:
We prefer to use idiomatic Python 3, instead of a back-port code, see the
conversion proposal in: https://s.apache.org/beam-python-3. When there are
concerns with Python 3 code being memory-inefficient we use
future.utils.iterkeys() of branch implementation based on version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 152264)
Time Spent: 2h 40m (was: 2.5h)
> Several IO tests fail in Python 3 with RuntimeError('dictionary changed size
> during iteration',)}
> -------------------------------------------------------------------------------------------------
>
> Key: BEAM-5626
> URL: https://issues.apache.org/jira/browse/BEAM-5626
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Ruoyun Huang
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> ERROR: test_delete_dir
> (apache_beam.io.hadoopfilesystem_test.HadoopFileSystemTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/hadoopfilesystem_test.py",
> line 506, in test_delete_dir
> self.fs.delete([url_t1])
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/hadoopfilesystem.py",
> line 370, in delete
> raise BeamIOError("Delete operation failed", exceptions)
> apache_beam.io.filesystem.BeamIOError: Delete operation failed with
> exceptions {'hdfs://test_dir/new_dir1': RuntimeError('dictionary changed size
> during iteration', )}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
