[
https://issues.apache.org/jira/browse/BEAM-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642035#comment-16642035
]
Scott Wegner commented on BEAM-5678:
------------------------------------
The [html-proofer|https://github.com/gjtorikian/html-proofer#ignoring-content]
extension that we use to validate URLs allows specifying a special
[{{data-proofer-ignore}}
|https://github.com/gjtorikian/html-proofer#ignoring-content] tag in the HTML
link to disable validation. We could use the custom redirect page functionality
to specify the tag.
This should be a sufficient work-around. Ideally we would like to validate that
our redirects do work, but since the redirect pages we're excluding are all
generated from the Jekyll plugin, the only reason they wouldn't work is due to
a bug in the plugin itself.
> Jeckyll redirect_from incompatible with HTMLProofer url validation
> ------------------------------------------------------------------
>
> Key: BEAM-5678
> URL: https://issues.apache.org/jira/browse/BEAM-5678
> Project: Beam
> Issue Type: Sub-task
> Components: website
> Reporter: Scott Wegner
> Priority: Minor
>
> Renaming a URL and using the Jekyll {{redirect_from}} feature breaks
> pre-commit validation.
> We hit this on
> [PR580|https://github.com/apache/beam-site/pull/580#issuecomment-427516952]:
> bq. The scenario for using a redirect is if you're moving {{pageA.md}} to
> {{pageB.md}}; you would rename the file to {{pageB.md}} and add
> {{redirect_from: pageA}}. This will cause jekyll to generate a {{pageA.html}}
> with a redirect to {{https://beam.apache.org/pageB.html}}. But {{pageB.html}}
> doesn't exist on the livesite yet, so it will always fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
