[
https://issues.apache.org/jira/browse/BEAM-5326?focusedWorklogId=152521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152521
]
ASF GitHub Bot logged work on BEAM-5326:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/18 05:27
Start Date: 09/Oct/18 05:27
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #6615:
[BEAM-5326] Shim main class and fix Go artifact naming mismatch for c…
URL: https://github.com/apache/beam/pull/6615#discussion_r223563424
##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflow.go
##########
@@ -149,10 +149,12 @@ func Execute(ctx context.Context, p *beam.Pipeline)
error {
return fmt.Errorf("failed to generate model pipeline: %v", err)
}
- id := atomic.AddInt32(&unique, 1)
- modelURL := gcsx.Join(*stagingLocation, fmt.Sprintf("model-%v-%v", id,
time.Now().UnixNano()))
- workerURL := gcsx.Join(*stagingLocation, fmt.Sprintf("worker-%v-%v",
id, time.Now().UnixNano()))
- jarURL := gcsx.Join(*stagingLocation,
fmt.Sprintf("dataflow-worker-%v-%v.jar", id, time.Now().UnixNano()))
+ // NOTE(herohde) 10/8/2018: the last segment of the names must be
"worker" and "dataflow-worker.jar".
Review comment:
If we are going to check in this code for now, could you pleas file a JIRA
for this NOTE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 152521)
Time Spent: 0.5h (was: 20m)
> SDK support for custom dataflow worker jar
> ------------------------------------------
>
> Key: BEAM-5326
> URL: https://issues.apache.org/jira/browse/BEAM-5326
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Henning Rohde
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Doc:
> https://docs.google.com/document/d/1-m-GzkYWIODKOEl1ZSUNXYbcGRvRr3QkasfHsJxbuoA/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
