[
https://issues.apache.org/jira/browse/BEAM-5615?focusedWorklogId=152891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152891
]
ASF GitHub Bot logged work on BEAM-5615:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/18 19:52
Start Date: 09/Oct/18 19:52
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #6570: [BEAM-5615] fix cmp
is an invalid keyword for sort function in python 3
URL: https://github.com/apache/beam/pull/6570
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/transforms/combiners.py
b/sdks/python/apache_beam/transforms/combiners.py
index 8db0fe5e14f..5742215861d 100644
--- a/sdks/python/apache_beam/transforms/combiners.py
+++ b/sdks/python/apache_beam/transforms/combiners.py
@@ -24,6 +24,7 @@
import random
from builtins import object
from builtins import zip
+from functools import cmp_to_key
from past.builtins import long
@@ -290,9 +291,12 @@ def __init__(self, n, compare=None, key=None,
reverse=False):
def _sort_buffer(self, buffer, lt):
if lt in (operator.gt, operator.lt):
buffer.sort(key=self._key_fn, reverse=self._reverse)
+ elif self._key_fn:
+ buffer.sort(key=cmp_to_key(
+ (lambda a, b: (not lt(self._key_fn(a), self._key_fn(b)))
+ - (not lt(self._key_fn(b), self._key_fn(a))))))
else:
- buffer.sort(cmp=lambda a, b: (not lt(a, b)) - (not lt(b, a)),
- key=self._key_fn)
+ buffer.sort(key=cmp_to_key(lambda a, b: (not lt(a, b)) - (not lt(b, a))))
def display_data(self):
return {'n': self._n,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 152891)
Time Spent: 2h 50m (was: 2h 40m)
> Several tests fail on Python 3 with TypeError: 'cmp' is an invalid keyword
> argument for this function
> -----------------------------------------------------------------------------------------------------
>
> Key: BEAM-5615
> URL: https://issues.apache.org/jira/browse/BEAM-5615
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-harness
> Reporter: Valentyn Tymofieiev
> Assignee: Juta Staes
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> ERROR: test_top (apache_beam.transforms.combiners_test.CombineTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/combiners_test.py",
> line 89, in test_top
> names) # Note parameter passed to comparator.
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pvalue.py",
> line 111, in __or__
> return self.pipeline.apply(ptransform, self)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pipeline.py",
> line 467, in apply
> label or transform.label)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pipeline.py",
> line 477, in apply
> return self.apply(transform, pvalueish)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pipeline.py",
> line 513, in apply
> pvalueish_result = self.runner.apply(transform, pvalueish)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/runner.py",
> line 193, in apply
> return m(transform, input)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/runner.py",
> line 199, in apply_PTransform
> return transform.expand(input)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/ptransform.py",
> line 759, in expand
> return self._fn(pcoll, *args, **kwargs)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/combiners.py",
> line 185, in Of
> TopCombineFn(n, compare, key, reverse), *args, **kwargs)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pvalue.py",
> line 111, in __or__
> return self.pipeline.apply(ptransform, self)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pipeline.py",
> line 513, in apply
> pvalueish_result = self.runner.apply(transform, pvalueish)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/runner.py",
> line 193, in apply
> return m(transform, input)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/runner.py",
> line 199, in apply_PTransform
> return transform.expand(input)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/core.py",
> line 1251, in expand
> default_value = combine_fn.apply([], *self.args, **self.kwargs)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/core.py",
> line 623, in apply
> *args, **kwargs)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/combiners.py",
> line 362, in extract_output
> self._sort_buffer(buffer, lt)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/combiners.py",
> line 295, in _sort_buffer
> key=self._key_fn)
> TypeError: 'cmp' is an invalid keyword argument for this function
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
