[
https://issues.apache.org/jira/browse/BEAM-5681?focusedWorklogId=153276&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153276
]
ASF GitHub Bot logged work on BEAM-5681:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Oct/18 20:39
Start Date: 10/Oct/18 20:39
Worklog Time Spent: 10m
Work Description: alanmyrvold commented on a change in pull request
#6608: [BEAM-5681] Fix website tasks when pull-request ID is specified
URL: https://github.com/apache/beam/pull/6608#discussion_r224233399
##########
File path: website/build.gradle
##########
@@ -230,11 +264,11 @@ publishWebsite.dependsOn commitWebsite
* ./gradlew :beam-website:stageWebsite -PgithubPullRequestId=${ghprbPullId}
-PwebsiteBucket=foo
*/
task stageWebsite << {
- assert project.hasProperty('githubPullRequestId')
- assert githubPullRequestId.isInteger()
+ // TODO: Refactor this duplication with build task
+ def baseUrl = project.findProperty('githubPullRequestId') ?
"${project.findProperty('githubPullRequestId')}" : 'latest'
Review comment:
Not sure this works ... I'm seeing the findProperty succeeding in non-PR
jobs with the value remaining the uninterpolated value,
--baseurl=/${ghprbPullId}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 153276)
Time Spent: 1h (was: 50m)
> [beam_PreCommit_Website_Cron] [testWebsite] Fails on URL checks
> ---------------------------------------------------------------
>
> Key: BEAM-5681
> URL: https://issues.apache.org/jira/browse/BEAM-5681
> Project: Beam
> Issue Type: Bug
> Components: test-failures, website
> Reporter: Scott Wegner
> Assignee: Alan Myrvold
> Priority: Major
> Labels: currently-failing
> Time Spent: 1h
> Remaining Estimate: 0h
>
> _Use this form to file an issue for test failure:_
> * [Jenkins Job|https://builds.apache.org/job/beam_PreCommit_Website_Cron/154]
> * [Gradle Build
> Scan|https://scans.gradle.com/s/k6ul7uyovyyce/console-log?task=:beam-website:testWebsite#L27]
> * [Test source
> code|https://github.com/apache/beam/blob/1c573ffba014f6969a689d0e6cdcace31358885d/website/build.gradle#L140]
> Initial investigation:
> It seems every link is failing. Same error message:
> {{- ./generated-content/beam/capability/2016/03/17/capability-matrix.html}}
> {{ * http:// is an invalid URL (line 76)}}
> {{ <a href="//" class="navbar-brand">}}
> {{ <img alt="Brand" style="height: 25px"
> src="//images/beam_logo_navbar.png">}}
> {{ </a>}}
> The _Cron version of this job has been failing consistently since 10/5
> ([history|https://builds.apache.org/job/beam_PreCommit_Website_Cron/])
> ----
> _After you've filled out the above details, please [assign the issue to an
> individual|https://beam.apache.org/contribute/postcommits-guides/index.html#find_specialist].
> Assignee should [treat test failures as
> high-priority|https://beam.apache.org/contribute/postcommits-policies/#assigned-failing-test],
> helping to fix the issue or find a more appropriate owner. See [Apache Beam
> Post-Commit
> Policies|https://beam.apache.org/contribute/postcommits-policies]._
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
