[
https://issues.apache.org/jira/browse/BEAM-5669?focusedWorklogId=153317&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153317
]
ASF GitHub Bot logged work on BEAM-5669:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Oct/18 23:20
Start Date: 10/Oct/18 23:20
Worklog Time Spent: 10m
Work Description: swegner opened a new pull request #6644: [BEAM-5669]
Ensure website publish doesn't create empty commits
URL: https://github.com/apache/beam/pull/6644
When checking if there are any changes to commit, only look at staged
changes. The default behavior of status.isClean() will return false if
there are staged or unstaged changes. There can be unstaged changes if
build side-effects produce extra artifacts in another directory.
Another solution would be to ignore other directories in .gitignore,
but if miss any new generated files we will once again produce empty
commits.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 153317)
Time Spent: 40m (was: 0.5h)
> Empty commits pushed by PostCommit_Website_Publish jenkins job
> --------------------------------------------------------------
>
> Key: BEAM-5669
> URL: https://issues.apache.org/jira/browse/BEAM-5669
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Affects Versions: 2.8.0
> Reporter: Alan Myrvold
> Assignee: Scott Wegner
> Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The isClean() call in
> https://github.com/apache/beam/blob/67562393de09e1e8e24c4a83ca5274f57c8379bb/website/build.gradle#L165
> is returning false due to unstaged .gradle and build files.
> The asf-site branch needs a .gitignore, which can be the same as the master
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
