[
https://issues.apache.org/jira/browse/BEAM-5698?focusedWorklogId=153416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153416
]
ASF GitHub Bot logged work on BEAM-5698:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/18 06:09
Start Date: 11/Oct/18 06:09
Worklog Time Spent: 10m
Work Description: HuangLED commented on a change in pull request #6626:
[BEAM-5698] Migrate Go integration test to use Dataflow worker jar
URL: https://github.com/apache/beam/pull/6626#discussion_r224324481
##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -79,7 +82,8 @@ echo ">>> RUNNING DATAFLOW INTEGRATION TESTS"
--environment_config=$CONTAINER:$TAG \
--staging_location=$GCS_LOCATION/staging-validatesrunner-test \
--temp_location=$GCS_LOCATION/temp-validatesrunner-test \
- --worker_binary=./sdks/go/test/build/bin/linux-amd64/worker
+ --worker_binary=./sdks/go/test/build/bin/linux-amd64/worker \
+ --dataflow_worker_jar=$DATAFLOW_WORKER_JAR
Review comment:
I assume this integration test wants to trigger portable runner code path
(apparently GO does not even have legacy world).
If that is the case, why triggering a job via portable runner does not
require a docker image in the command line? versus the HOW-TO
https://g3doc.corp.google.com/cloud/dataflow/portability/g3doc/howto.md?cl=head
I had the hypothesis that, maybe under the hood, what is inside JAR is
essentially equivalent to what is in docker image. But if that is the case, why
don't we stick with using docker image.
What am I missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 153416)
Time Spent: 1.5h (was: 1h 20m)
> Migrate Dataflow tests to use a staged dataflow worker jar
> ----------------------------------------------------------
>
> Key: BEAM-5698
> URL: https://issues.apache.org/jira/browse/BEAM-5698
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Henning Rohde
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Needs to be done for all Dataflow testing at HEAD for all SDKs, except legacy
> Python batch. For java legacy jobs, we should not specify a worker harness
> container image.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
