[
https://issues.apache.org/jira/browse/BEAM-5467?focusedWorklogId=153466&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153466
]
ASF GitHub Bot logged work on BEAM-5467:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/18 09:50
Start Date: 11/Oct/18 09:50
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6532:
[BEAM-5467] Use process SDKHarness to run flink PVR tests.
URL: https://github.com/apache/beam/pull/6532#discussion_r224385167
##########
File path: sdks/python/build.gradle
##########
@@ -379,3 +405,21 @@ task buildSnapshot() {
dependsOn 'sdist'
dependsOn 'depSnapshot'
}
+
+project.task('createProcessWorker') {
+ dependsOn ':beam-sdks-python-container:build'
+ dependsOn 'setupVirtualenv'
+ def sdkWorkerFile = file("${project.buildDir}/sdk_worker.sh")
+ def workerScript =
"${project(":beam-sdks-python-container:").buildDir.absolutePath}/target/launcher/linux_amd64/boot"
+ def sdkWorkerFileCode = "sh -c \". ${envdir}/bin/activate && ${workerScript}
\$* \""
Review comment:
I suppose we want to resolve the paths dynamically based on the build
directory. For the sake of simplicity, we could also directly write this to
environment_config and use relative paths. IMHO ok to leave it like it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 153466)
Time Spent: 9.5h (was: 9h 20m)
> Python Flink ValidatesRunner job fixes
> --------------------------------------
>
> Key: BEAM-5467
> URL: https://issues.apache.org/jira/browse/BEAM-5467
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Minor
> Labels: portability-flink
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> Add status to README
> Rename script and job for consistency
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
