[
https://issues.apache.org/jira/browse/BEAM-5623?focusedWorklogId=153658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153658
]
ASF GitHub Bot logged work on BEAM-5623:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/18 19:16
Start Date: 11/Oct/18 19:16
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #6648: [BEAM-5623] Skip
tests that halt test suite execution on Python 3
URL: https://github.com/apache/beam/pull/6648
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/io/textio_test.py
b/sdks/python/apache_beam/io/textio_test.py
index 1bc54eeca35..218e154c640 100644
--- a/sdks/python/apache_beam/io/textio_test.py
+++ b/sdks/python/apache_beam/io/textio_test.py
@@ -161,6 +161,9 @@ def test_read_single_file_single_line_no_eol_gzip(self):
self._run_read_test(gzip_file_name, expected_data,
compression=CompressionTypes.GZIP)
+ @unittest.skipIf(sys.version_info[0] == 3,
+ 'This test halts test suite execution on Python 3. '
+ 'TODO: BEAM-5623')
def test_read_empty_single_file_no_eol_gzip(self):
file_name, written_data = write_data(
1, no_data=True, eol=EOL.LF_WITH_NOTHING_AT_LAST_LINE)
diff --git a/sdks/python/apache_beam/io/tfrecordio_test.py
b/sdks/python/apache_beam/io/tfrecordio_test.py
index 3534eaa594a..f32d46a8cc0 100644
--- a/sdks/python/apache_beam/io/tfrecordio_test.py
+++ b/sdks/python/apache_beam/io/tfrecordio_test.py
@@ -26,6 +26,7 @@
import pickle
import random
import re
+import sys
import unittest
from builtins import range
@@ -271,6 +272,9 @@ def test_process_gzip(self):
validate=True))
assert_that(result, equal_to(['foo', 'bar']))
+ @unittest.skipIf(sys.version_info[0] == 3,
+ 'This test halts test suite execution on Python 3. '
+ 'TODO: BEAM-5623')
def test_process_auto(self):
with TempDir() as temp_dir:
path = temp_dir.create_temp_file('result.gz')
@@ -284,6 +288,9 @@ def test_process_auto(self):
validate=True))
assert_that(result, equal_to(['foo', 'bar']))
+ @unittest.skipIf(sys.version_info[0] == 3,
+ 'This test halts test suite execution on Python 3. '
+ 'TODO: BEAM-5623')
def test_process_gzip(self):
with TempDir() as temp_dir:
path = temp_dir.create_temp_file('result')
@@ -294,6 +301,9 @@ def test_process_gzip(self):
path, compression_type=CompressionTypes.GZIP))
assert_that(result, equal_to(['foo', 'bar']))
+ @unittest.skipIf(sys.version_info[0] == 3,
+ 'This test halts test suite execution on Python 3. '
+ 'TODO: BEAM-5623')
def test_process_gzip_auto(self):
with TempDir() as temp_dir:
path = temp_dir.create_temp_file('result.gz')
@@ -364,6 +374,9 @@ def test_process_multiple_globs(self):
compression_type=CompressionTypes.AUTO))
assert_that(result, equal_to(['foo', 'bar'] * 9))
+ @unittest.skipIf(sys.version_info[0] == 3,
+ 'This test halts test suite execution on Python 3. '
+ 'TODO: BEAM-5623')
def test_process_gzip(self):
with TempDir() as temp_dir:
path = temp_dir.create_temp_file('result')
@@ -376,6 +389,9 @@ def test_process_gzip(self):
compression_type=CompressionTypes.GZIP))
assert_that(result, equal_to(['foo', 'bar']))
+ @unittest.skipIf(sys.version_info[0] == 3,
+ 'This test halts test suite execution on Python 3. '
+ 'TODO: BEAM-5623')
def test_process_auto(self):
with TempDir() as temp_dir:
path = temp_dir.create_temp_file('result.gz')
diff --git a/sdks/python/apache_beam/runners/portability/stager_test.py
b/sdks/python/apache_beam/runners/portability/stager_test.py
index 9edc4eb4a2d..922a7211b11 100644
--- a/sdks/python/apache_beam/runners/portability/stager_test.py
+++ b/sdks/python/apache_beam/runners/portability/stager_test.py
@@ -223,9 +223,9 @@ def test_with_requirements_file_and_cache(self):
self.assertTrue(os.path.isfile(os.path.join(staging_dir, 'abc.txt')))
self.assertTrue(os.path.isfile(os.path.join(staging_dir, 'def.txt')))
- # TODO(BEAM-5502): Object stager tests are not hermetic.
- @unittest.skipIf(sys.version_info[0] == 3, 'This test still needs to be '
- 'fixed on Python 3')
+ @unittest.skipIf(sys.version_info[0] == 3, 'This test is not hermetic '
+ 'and halts test suite execution on Python 3. '
+ 'TODO: BEAM-5502')
def test_with_setup_file(self):
staging_dir = self.make_temp_dir()
source_dir = self.make_temp_dir()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 153658)
Time Spent: 50m (was: 40m)
> Several IO tests hang indefinitely during execution on Python 3.
> ----------------------------------------------------------------
>
> Key: BEAM-5623
> URL: https://issues.apache.org/jira/browse/BEAM-5623
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> test_read_empty_single_file_no_eol_gzip
> (apache_beam.io.textio_test.TextSourceTest)
> Also several tests cases in tfrecordio_test, for example:
> test_process_auto (apache_beam.io.tfrecordio_test.TestReadAllFromTFRecord)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
