[ https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=153972&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153972 ]
ASF GitHub Bot logged work on BEAM-4176: ---------------------------------------- Author: ASF GitHub Bot Created on: 12/Oct/18 18:13 Start Date: 12/Oct/18 18:13 Worklog Time Spent: 10m Work Description: angoenka commented on a change in pull request #6592: [BEAM-4176] Enable Post Commit JAVA PVR tests for Flink URL: https://github.com/apache/beam/pull/6592#discussion_r224873292 ########## File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/ReferenceCountingFlinkExecutableStageContextFactory.java ########## @@ -104,9 +108,21 @@ private void scheduleRelease(JobInfo jobInfo) { WrappedContext wrapper = getCache().get(jobInfo.jobId()); Preconditions.checkState( wrapper != null, "Releasing context for unknown job: " + jobInfo.jobId()); - // Do not release this asynchronously, as the releasing could fail due to the classloader not being - // available anymore after the tasks have been removed from the execution engine. - release(wrapper); + + PipelineOptions pipelineOptions = + PipelineOptionsTranslation.fromProto(jobInfo.pipelineOptions()); + int environmentCacheTTLMillis = + pipelineOptions.as(PortablePipelineOptions.class).getEnvironmentCacheMillis(); + if (environmentCacheTTLMillis > 0) { + // Schedule task to clean the container later. + // Ensure that this class is loaded in the parent Flink classloader. + getExecutor() + .schedule(() -> release(wrapper), environmentCacheTTLMillis, TimeUnit.MILLISECONDS); Review comment: Maybe I am missing some thing. For this PR, I based my branch java_pvr_jenkins on java_pvr_cache_environments and then created the PR (merge 1 commit into apache:master from angoenka:java_pvr_jenkins). This picks the commits from both branches java_pvr_jenkins and java_pvr_cache_environments. Is there anyway to avoid picking commits from the base PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 153972) Time Spent: 33h 20m (was: 33h 10m) > Java: Portable batch runner passes all ValidatesRunner tests that > non-portable runner passes > -------------------------------------------------------------------------------------------- > > Key: BEAM-4176 > URL: https://issues.apache.org/jira/browse/BEAM-4176 > Project: Beam > Issue Type: Bug > Components: runner-flink > Reporter: Ben Sidhom > Assignee: Ankur Goenka > Priority: Major > Attachments: 81VxNWtFtke.png, Screen Shot 2018-08-14 at 4.18.31 > PM.png, Screen Shot 2018-09-03 at 11.07.38 AM.png > > Time Spent: 33h 20m > Remaining Estimate: 0h > > We need this as a sanity check that runner execution is correct. -- This message was sent by Atlassian JIRA (v7.6.3#76005)