[beam] branch master updated: Fixing nested records test. Testing only BQ, not Side Inputs

[pabloem]

This is an automated email from the ASF dual-hosted git repository.

pabloem pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 834f7a3  Fixing nested records test. Testing only BQ, not Side Inputs
     new 7bc5599  Merge pull request #7620 from pabloem/nestedrecords
834f7a3 is described below

commit 834f7a31c83d83bf76cac403d2fbcff81baf2ec1
Author: Pablo <pabl...@google.com>
AuthorDate: Thu Jan 24 15:00:01 2019 -0800

    Fixing nested records test. Testing only BQ, not Side Inputs
---
 .../io/gcp/bigquery/BigQueryNestedRecordsIT.java   | 42 ----------------------
 1 file changed, 42 deletions(-)

diff --git 
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryNestedRecordsIT.java
 
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryNestedRecordsIT.java
index 7a22f62..872faa2 100644
--- 
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryNestedRecordsIT.java
+++ 
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryNestedRecordsIT.java
@@ -27,12 +27,7 @@ import org.apache.beam.sdk.options.PipelineOptionsFactory;
 import org.apache.beam.sdk.testing.PAssert;
 import org.apache.beam.sdk.testing.TestPipeline;
 import org.apache.beam.sdk.testing.TestPipelineOptions;
-import org.apache.beam.sdk.transforms.Create;
-import org.apache.beam.sdk.transforms.DoFn;
-import org.apache.beam.sdk.transforms.ParDo;
-import org.apache.beam.sdk.transforms.View;
 import org.apache.beam.sdk.values.PCollection;
-import org.apache.beam.sdk.values.PCollectionView;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -93,40 +88,6 @@ public class BigQueryNestedRecordsIT {
                 .fromQuery(options.getUnflattenableInput())
                 .withoutResultFlattening());
 
-    final PCollectionView<Iterable<TableRow>> flattenedView =
-        flattenedCollection.apply("PCViewFlattened", View.asIterable());
-    PCollection<TableRow> flattenedSideInput =
-        p.apply("Create1", Create.of(1))
-            .apply(
-                "ReadFlattenedSI",
-                ParDo.of(
-                        new DoFn<Integer, TableRow>() {
-                          @ProcessElement
-                          public void processElement(ProcessContext c) {
-                            for (TableRow r : c.sideInput(flattenedView)) {
-                              c.output(r);
-                            }
-                          }
-                        })
-                    .withSideInputs(flattenedView));
-
-    final PCollectionView<Iterable<TableRow>> nonFlattenedView =
-        nonFlattenedCollection.apply("PCViewNonFlattened", View.asIterable());
-    PCollection<TableRow> nonFlattenedSideInput =
-        p.apply("Create2", Create.of(1))
-            .apply(
-                "ReadNonFlattenedSI",
-                ParDo.of(
-                        new DoFn<Integer, TableRow>() {
-                          @ProcessElement
-                          public void processElement(ProcessContext c) {
-                            for (TableRow r : c.sideInput(nonFlattenedView)) {
-                              c.output(r);
-                            }
-                          }
-                        })
-                    .withSideInputs(nonFlattenedView));
-
     // Also query BigQuery directly.
     BigqueryClient bigQueryClient = new 
BigqueryClient(bigQueryOptions.getAppName());
 
@@ -148,12 +109,9 @@ public class BigQueryNestedRecordsIT {
 
     // Verify that the results are the same.
     PAssert.thatSingleton(flattenedCollection).isEqualTo(queryFlattenedTyped);
-    PAssert.thatSingleton(flattenedSideInput).isEqualTo(queryFlattenedTyped);
     PAssert.thatSingleton(nonFlattenedCollection).isEqualTo(queryUnflattened);
-    PAssert.thatSingleton(nonFlattenedSideInput).isEqualTo(queryUnflattened);
     
PAssert.thatSingleton(unflattenableCollection).isEqualTo(queryUnflattenable);
 
-    // And that flattened results are different from non-flattened results.
     PAssert.thatSingleton(flattenedCollection).notEqualTo(queryUnflattened);
     p.run().waitUntilFinish();
   }